build: activate correct default flags for riscv64 - #65708
Merged
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Collaborator
aduh95
approved these changes
Sep 1, 2026
Member
I think this has been fixed in google/highway@4a43b15, though I haven't tested it. Edit: V8 hasn't bumped highway for a long time so this fix has not reached v8 yet. |
Collaborator
sxa
added
the
commit-queue
richardlau
approved these changes
Sep 3, 2026
Collaborator
|
Landed in c6ab55c |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables two default flags to control the build on RISC-V.
-march=rv64gcstops the compiler from creating a binary which may have vector (RVV) instructions. The machines that we would use for building on RISC-V tend to have vector instructions and so the compilers on those distributions will be likely to be creating RVV (rv64gc) code by default. This does not impact V8's ability to generate vector instructions at runtime and exploit them on newer machines that have them.